Activity (RSS)

Hi Dan,

Yes, the change loads on Rubinius. Sorry about taking so long to get back to you.

BTW it looks like there are benchmarks in extlib/benchmarks for this.

Jacques: Would you mind making a failing spec and sending a pull request or patch for this feature?

It looks like the original reason for the Extlib version was...

Brian, I just pushed a fix to extlib a moment ago:

http://github.com/datamapper/ext...

Would you mind giving it a spin and let me know if it resolves this issu...

Here's one possible patch.

5c5,7
<   ((Array.instance_methods(false) | Enumerable.instance_methods(false)).map { |m| m.to_s } - %w[ taguri= ]).each do |meth...

LazyArray dynamically defines all the Array and Enumerable instance methods on itself. However, it does not account for the difference in assignment methods. Wh...

This is now resolved as per the following commit:

http://github.com/datamapper/ext...

Yeah, I'd love to have DM::Logger inherit from Extlib::Logger, but I don't want to remove the Merb specific stuff for fear of breaking something in Merb.

Oh, DM currently isn't using the logger, but we'd like to. Also, i think in general principle, the point of extlib was to not be dependent on things.

http://github.com/sam/extlib/blo...

Having extlib logger use the Merb constant means we can't use DataMapper as a standalone app.

At the very least, there shou...

This was resolved by:

http://github.com/sam/extlib/com...

I have fixed this bug in my fork of extlib at github.com/startrader/extlib. Test cases included

This is a duplicate of Datamapper bug #759

require 'extlib'

class Person
  include Extlib::Hook
  attr_accessor :name

  def valid?
    !name.nil?
  end

end
...

I created trivial patches to remove the dependencies in extlib and to set the merb log level in merb based on environment, but they broke tests in merb-core/spe...

Extlib::Logger.set_log references Merb.environment and sets Merb.logger

Inflection module originally from DM duplicates Merb-core String extensions. Some methods do not exactly same thing but very very close.

Object#full_const_get and Module#find_const seem to do pretty much the same thing.