Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Extlib Logger is dependent on merb

#6

http://github.com/sam/extlib/blo...

Having extlib logger use the Merb constant means we can't use DataMapper as a standalone app.

At the very least, there should be a const_defined?("Merb") check. Even better, remove it entirely, and let the merb guys worry about merb-specific logging chores.

Reported by Paul Sadauskas (Rando) · January 19th, 2009 @ 07:56 PM

State: resolved
Milestone: none
Assigned to: nobody

Activity

  1. Paul Sadauskas (Rando)
    Paul Sadauskas (Rando)
    • Tag set to logger

    Oh, DM currently isn't using the logger, but we'd like to. Also, i think in general principle, the point of extlib was to not be dependent on things.

    January 19th, 2009 @ 07:58 PM

  2. Dan Kubb (dkubb)
    Dan Kubb (dkubb)

    Yeah, I'd love to have DM::Logger inherit from Extlib::Logger, but I don't want to remove the Merb specific stuff for fear of breaking something in Merb.

    January 26th, 2009 @ 11:18 PM

  3. Dan Kubb (dkubb)
    Dan Kubb (dkubb)
    • State changed from new to resolved

    This is now resolved as per the following commit:

    http://github.com/datamapper/ext...

    January 28th, 2009 @ 02:13 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.