Extlib Logger is dependent on merb
Reported by Paul Sadauskas (Rando) | January 19th, 2009 @ 07:56 PM
http://github.com/sam/extlib/blo...
Having extlib logger use the Merb constant means we can't use DataMapper as a standalone app.
At the very least, there should be a const_defined?("Merb") check. Even better, remove it entirely, and let the merb guys worry about merb-specific logging chores.
Comments and changes to this ticket
-
Paul Sadauskas (Rando) January 19th, 2009 @ 07:58 PM
- Tag set to “logger”
Oh, DM currently isn't using the logger, but we'd like to. Also, i think in general principle, the point of extlib was to not be dependent on things.
-
Dan Kubb (dkubb) January 26th, 2009 @ 11:18 PM
Yeah, I'd love to have DM::Logger inherit from Extlib::Logger, but I don't want to remove the Merb specific stuff for fear of breaking something in Merb.
-
Dan Kubb (dkubb) January 28th, 2009 @ 02:13 AM
- State changed from “new” to “resolved”
This is now resolved as per the following commit:
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Lightweight fast Ruby core extensions library for DataMapper and Merb.
Lin Jen-Shin
Paul Sadauskas (Rando)